Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix for ipv6 link local with scope (#9326)" #9375

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 14, 2022

This reverts commit c1abc7f. It
produced compilation issues inside Google. I strongly suspect it isn't
this commit or gRPC's fault, but it prevents further testing until it is
resolved.

CC @jader-eero

I'll also be reverting this from the release branch. We have actually had quite a bit of trouble with the import, and we were able to resolve lots of issues semi-quickly, but we had wanted to do builds on Tuesday yet some of the commits still haven't been tested more widely. There's some ugly things to dig into for this one that will simply take too long and we don't want to delay the entire release even further. It seems highly likely there will be a 1.48.1 soon after the 1.48.0 release, so hopefully this change can make it into that.

This reverts commit c1abc7f. It
produced compilation issues inside Google. I strongly suspect it isn't
this commit or gRPC's fault, but it prevents further testing until it is
resolved.
@ejona86 ejona86 requested a review from sergiitk July 14, 2022 16:24
@ejona86 ejona86 merged commit 55fd626 into grpc:master Jul 14, 2022
@ejona86 ejona86 deleted the revert-ipv6-scope branch July 14, 2022 18:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants