clientconn: return ctx.Err() on getTransport failure if non-nil #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, closing the client with FailFast=false causes outstanding RPCs to spin forever.
|
Confirmed that this fixes the issue in etcd etcd-io/etcd#6221. /cc @iamqizhao @menghanl Thanks! |
| @@ -506,6 +506,9 @@ func (cc *ClientConn) getTransport(ctx context.Context, opts BalancerGetOptions) | |||
| if put != nil { | |||
| put() | |||
| } | |||
| if ctx.Err() != nil { | |||
|
Thanks for the reporting. This is not the right fix though. Let us take this over. will send the fix shortly. |
|
replaced by #842 |
Can you please be more clear about why this is not the right fix next time? So that other people can understand it better. Thank you. |
|
The root cause is that getTransport does not detect ClientConn has been closed in this case. This PR fixed the symptom for a cancelled rpc instead of the root case. The bug remains if this rpc is not cancelled/timeout with this PR. |
|
Thanks for the explanation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, closing the client with FailFast=false causes outstanding RPCs to
spin forever.
/cc @gyuho