etcd-tester: request with grpc.FailFast true #6224
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6221.
Since we close the grpc connection, FailFast false
will block.
When we cancel stresser, we close grpc connection (https://github.com/coreos/etcd/blob/master/tools/functional-tester/etcd-tester/stresser.go#L281). This will cause
errConnClosing
in grpc side (https://github.com/grpc/grpc-go/blob/master/call.go#L173), hanging with grpc FailFast false.We should use grpc FailFast true as in clientv3.