security/authorization: util function for converting CEL expression string #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhenLian
force-pushed
the
zhen_cel_util
branch
from
6f66927 to
e327604
Compare
ZhenLian
force-pushed
the
zhen_cel_util
branch
from
e327604 to
2aca658
Compare
easwars
requested changes
Aug 17, 2020
| } { | ||
| test := test | ||
| t.Run(test.desc, func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
Any specific reason to run these tests in parallel?
Do they run for long? Do they block on something, therefore running in parallel makes sense?
There was a problem hiding this comment.
No, I just saw the usage of t.Parallel somewhere, and thought it might help speed up the tests.
I'll remove it since this is a small test.
easwars
approved these changes
Aug 18, 2020
|
@easwars Thanks a lot for the review! Merging now... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fork for #3805.
This PR aims to add a util function to convert a CEL expression string to the complied format(cel.CheckedExpr).