security/authorization: add integration tests #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhenLian
reviewed
Aug 17, 2020
ZhenLian
suggested changes
Aug 17, 2020
added 4 commits
August 19, 2020 16:01
…ng, changed Errorf to Fatalf for fail to construct engine
…helper function to util.go
ZhenLian
suggested changes
Aug 20, 2020
ZhenLian
approved these changes
Aug 21, 2020
easwars
requested changes
Aug 21, 2020
added 3 commits
August 21, 2020 12:08
easwars
requested changes
Aug 21, 2020
| @@ -66,6 +75,18 @@ func (mock valMock) Value() interface{} { | |||
| return mock.val | |||
| } | |||
|
|
|||
| type addrMock struct { | |||
There was a problem hiding this comment.
Is it possible to use a net.IPAddr instead? I don't see this mock addr adding much value here.
easwars
approved these changes
Aug 26, 2020
|
Thanks @wflms20110333 for the great work and @easwars for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZhenLian
Also added helper functions
compileCelandconvertStringToCheckedExpr, which should be removed when #3805 is merged.