error details: add @type key by switching to any.Any #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is arguably more correct than what was introduced in grpc-ecosystem#515. So, any error details no have a "@type" field indicating their underlying proto.Message's type, following the Cloud API docs[1]. [1]: https://cloud.google.com/apis/design/errors#http_mapping Signed-off-by: Stephan Renatus <[email protected]>
|
Good catch! Thanks for taking the time to fix it for everyone |
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
) This is arguably more correct than what was introduced in grpc-ecosystem#515. So, any error details no have a "@type" field indicating their underlying proto.Message's type, following the Cloud API docs[1]. [1]: https://cloud.google.com/apis/design/errors#http_mapping Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is arguably more correct than what was introduced in #515. So, any
error details no have a "@type" field indicating their underlying
proto.Message's type, following the Cloud API docs1.
Note that this does not help with #551. The error is still present.