add error details to error json #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I'm not sure I understand what is happening on travis. Could someone please have a look and share a hint? 😉 |
|
@tmc do you have any thoughts on this? |
|
I'm having the same problem in #489. It seems some commit between go 1.9 and If someone finds a fix to this, keep me posted on my PR, please. |
|
Looking at this, it seems to me that the test we have for the go version is just wrong and it is running our clean test against go master and go 1.9. I fixed it in #520. I'm going to get lunch and let the CI run then merge that. Sorry for all the trouble. It was an interesting bug if you wanna stare at it. |
|
Could you rebase this onto the current HEAD? I updated the travis config so this shouldn't be a problem any more. |
srenatus
force-pushed
the
sr/fix-405/add-error-details-to-error-json
branch
from
982e89b
to
0c4d78a
Compare
achew22
reviewed
Jan 11, 2018
| @@ -248,6 +249,21 @@ func (s *_ABitOfEverythingServer) Timeout(ctx context.Context, msg *empty.Empty) | |||
| } | |||
| } | |||
|
|
|||
| func (s *_ABitOfEverythingServer) ErrorWithDetails(ctx context.Context, msg *empty.Empty) (*empty.Empty, error) { | |||
| stat := status.New(codes.Unknown, "with details") | |||
There was a problem hiding this comment.
I think it would be better to collapse the next few lines
stat, err := status.New(codes.Unknown, "with details").
WithDetails([]proto.message{
...
})
0c4d78a
to
5283d2e
Compare
Fixes grpc-ecosystem#405. If we go with this, that is. In a separate commit, I'll update the generated files. Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/fix-405/add-error-details-to-error-json
branch
from
5283d2e
to
1a446cc
Compare
srenatus
added a commit
to srenatus/grpc-gateway
that referenced
this pull request
Feb 21, 2018
This is arguably more correct than what was introduced in grpc-ecosystem#515. So, any error details no have a "@type" field indicating their underlying proto.Message's type, following the Cloud API docs[1]. [1]: https://cloud.google.com/apis/design/errors#http_mapping Signed-off-by: Stephan Renatus <[email protected]>
achew22
pushed a commit
that referenced
this pull request
Feb 23, 2018
This is arguably more correct than what was introduced in #515. So, any error details no have a "@type" field indicating their underlying proto.Message's type, following the Cloud API docs[1]. [1]: https://cloud.google.com/apis/design/errors#http_mapping Signed-off-by: Stephan Renatus <[email protected]>
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Signed-off-by: Stephan Renatus <[email protected]>
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
) This is arguably more correct than what was introduced in grpc-ecosystem#515. So, any error details no have a "@type" field indicating their underlying proto.Message's type, following the Cloud API docs[1]. [1]: https://cloud.google.com/apis/design/errors#http_mapping Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to pick up where the discussion in #405 has trailed off.
I'm not sure about the import changes of the generated api_clients, but I'll see what happens when travis comes in.