Editor contents disappear after removing field from the Outline View

[mauromol]

Consider the example in #943.

From the Outline View select foobar, press Del key and confirm. In this case, the Outline View is updated. However now try to click inside the open editor for class Test54: the whole editor contents will disappear, showing just line numbers:

[mauromol]

Please note that I can reproduce this often, but not always. In general what I see is that after the above action on the foobar field, the editor seems to be "redrawn" badly, like if the underlying model is not in synch with actual contents. For instance, the vertical ruler on the left might show 10 lines while the file has just 9 lines and you can't put the cursor on line 10 (it's not even an empty line), or vice versa, showing contents for 10 lines and having the vertical ruler count lines up to 9.

[eric-milles]

This comes down to setting the proper source offsets on the JDT AST nodes. The end offset is intruding into the line delimiter "\r\n". When this gets cut in half, the editor has problems with a bare "\r".

[eric-milles]

ready to test

[mauromol]

Works fine in 3.5.0.v201908272143-e1906, thank you!