Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline View not updated after field removal from the Outline View itself #943

Closed
mauromol opened this issue Aug 22, 2019 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@mauromol
Copy link

mauromol commented Aug 22, 2019

Consider this class:

package test54

import javax.annotation.Resource

class Test54 {
	String foo
	
	String bar
	
	@Resource
	String foobar
}

From the Outline View, select bar, press Del key and confirm deletion: the bar property gets deleted, but the Outline View is not updated and still shows it.

Please note that in other "real-world" scenarios I get a slightly different behaviour: the view is somewhat updated, but it still shows the deleted field with a question mark (instead of the standard property icon) on its left. Please see the following example, where I deleted the token field from the Outline View:

immagine

@eric-milles
Copy link
Member

The editor action ConvertToMethodAction is running between the field removal and the reconcile that builds the delta used to update the outline view. It is running its own reconcile to determine of the current editor selection is an applicable element.

@eric-milles eric-milles self-assigned this Aug 22, 2019
@eric-milles eric-milles added this to the v3.5.0 milestone Aug 22, 2019
@eric-milles
Copy link
Member

ready to test

@mauromol
Copy link
Author

If I delete foo or bar it works correctly now with 3.5.0.v201908222034-e1906.
If I try to delete foobar bad things still happen, see #944.

@mauromol
Copy link
Author

It works fine also in my main project when deleting AuthenticationToken.token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants