Select — Add theme.select.clear.container.hover
#7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halocline
approved these changes
Oct 24, 2024
MikeKingdom
reviewed
Oct 24, 2024
| </Box> | ||
| {({ hover }) => ( | ||
| <Box | ||
| {...theme.select.clear.container} |
There was a problem hiding this comment.
Won't this accidentally put a hover=[object, object] on the Box?
There was a problem hiding this comment.
It wasn't passing it to the DOM so originally I was okay with that, but I've added one more step to avoid it being passed in React props as well:
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ability for caller to define hover styling for Clear selection container.
Adds
plainto Button to maintain previous "plain" functionality of the Button once we switch into the function notation.Where should the reviewer start?
src/js/components/Select/SelectContainer.js
What testing has been done on this PR?
Local in storybook and test added:
Screen.Recording.2024-10-23.at.3.43.38.PM.mov
How should this be manually tested?
Do Jest tests follow these best practices?
screenis used for querying.asFragment()is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
Closes #7342
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes.
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.