add all docs for release in November #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
MikeKingdom
reviewed
Nov 12, 2024
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.small.range.round"> | ||
| <Description> | ||
| The amount to round the corner days in range when small. |
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.small.range.round.end"> | ||
| <Description> | ||
| The amount to round the corner days in range when small. |
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.small.range.round.start"> | ||
| <Description> | ||
| The amount to round the corner days in range when small. |
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.medium.range.round"> | ||
| <Description> | ||
| The amount to round the corner days in range when medium. |
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.large.range.round.start"> | ||
| <Description> | ||
| The amount to round the corner days in range when large. |
src/screens/Calendar.js
Outdated
|
|
||
| <Property name="calendar.large.range.round.end"> | ||
| <Description> | ||
| The amount to round the corner days in range when large. |
src/screens/Notification.js
Outdated
| @@ -361,6 +361,22 @@ background: { | |||
| <Example defaultValue>"background-front"</Example> | |||
| </PropertyValue> | |||
| </Property> | |||
| <Property name="notification.critical.message.color"> | |||
| <Description>The color of the message.</Description> | |||
There was a problem hiding this comment.
These should be more specific (e.g. The color of the message text for critical status.)
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
taysea
reviewed
Nov 12, 2024
Co-authored-by: Mike Kingdom <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Taylor Seamans <[email protected]>
Co-authored-by: Mike Kingdom <[email protected]>
Co-authored-by: Mike Kingdom <[email protected]>
taysea
reviewed
Nov 13, 2024
src/screens/Calendar.js
Outdated
| <Example>"any CSS size"</Example> | ||
| </PropertyValue> | ||
| <PropertyValue type="object"> | ||
| <Example>{`{ size: "...", corner: "..." }`}</Example> |
There was a problem hiding this comment.
We're having to copy and paste this a lot of times -- is there room to abstract it into reusable example?
taysea
reviewed
Nov 13, 2024
| @@ -361,6 +361,30 @@ background: { | |||
| <Example defaultValue>"background-front"</Example> | |||
| </PropertyValue> | |||
| </Property> | |||
| <Property name="notification.critical.message.color"> | |||
There was a problem hiding this comment.
It looks like we're missing the kind specific options for each status
notification.critical.global.message.color
notification.critical.toast.message.color
taysea
approved these changes
Nov 13, 2024
MikeKingdom
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding all of the new theme changes for November release.
grommet/grommet#7408
grommet/grommet#7397
grommet/grommet#7384
grommet/grommet#7390
grommet/grommet#7409
grommet/grommet#7411
grommet/grommet#7402
grommet/grommet#7386
can be merged after release.