Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules updated to default to 'warn' #32

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Sep 8, 2022

What does this PR do?

Updates recommended config to default rules to "warn" -- we rules should be inline help/educational but not prohibit people from commiting code.

Where should the reviewer start?

Can you provide a link to an AST Explorer example that validates the rule works as expected?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Have docs been added/updated?

Should this PR be mentioned in the release notes?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from halocline September 8, 2022 21:59
Copy link
Collaborator

@halocline halocline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do each of the rule.meta.types need to be changed to 'suggestion' instead of problem?

@taysea
Copy link
Collaborator Author

taysea commented Sep 9, 2022

Question: Do each of the rule.meta.types need to be changed to 'suggestion' instead of problem?

Good question, I will have a look at that an adjust as necessary.

@taysea taysea merged commit 6cdc188 into master Sep 9, 2022
@taysea taysea deleted the recommended-config-defaults branch September 9, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants