Merge pull request #32 from grommet/recommended-config-defaults

Rules updated to default to 'warn'
grommet · Sep 9, 2022 · 6cdc188 · 6cdc188
2 parents 9648622 + 95074a0
commit 6cdc188
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 11 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -22,15 +22,15 @@ module.exports.configs = {
     plugins: ['grommet'],
     rules: {
       'grommet/anchor-label': 'warn',
-      'grommet/button-icon-a11ytitle': 'error',
-      'grommet/button-single-kind': 'error',
-      'grommet/datatable-aria-describedby': 'error',
-      'grommet/datatable-groupby-onmore': 'error',
-      'grommet/formfield-htmlfor-id': 'error',
-      'grommet/formfield-name': 'error',
-      'grommet/formfield-prefer-children': 'error',
-      'grommet/image-alt-text': 'error',
-      'grommet/spinner-message': 'error',
+      'grommet/button-icon-a11ytitle': 'warn',
+      'grommet/button-single-kind': 'warn',
+      'grommet/datatable-aria-describedby': 'warn',
+      'grommet/datatable-groupby-onmore': 'warn',
+      'grommet/formfield-htmlfor-id': 'warn',
+      'grommet/formfield-name': 'warn',
+      'grommet/formfield-prefer-children': 'warn',
+      'grommet/image-alt-text': 'warn',
+      'grommet/spinner-message': 'warn',
     },
   },
 };
diff --git a/lib/rules/anchor-label.js b/lib/rules/anchor-label.js
@@ -10,6 +10,7 @@
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Rule to enforce descriptive anchor label',
       category: 'Best Practices',

diff --git a/lib/rules/button-icon-a11ytitle.js b/lib/rules/button-icon-a11ytitle.js
@@ -10,6 +10,7 @@
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Rule to enforce a11yTitle on icon-only buttons',
       category: 'Best Practices',

diff --git a/lib/rules/button-single-kind.js b/lib/rules/button-single-kind.js
@@ -10,7 +10,7 @@
 
 module.exports = {
   meta: {
-    type: 'problem',
+    type: 'suggestion',
     docs: {
       description: 'Rule to ensure Button does not have multiple kinds applied',
       category: 'Best Practices',

diff --git a/lib/rules/formfield-htmlfor-id.js b/lib/rules/formfield-htmlfor-id.js
@@ -10,6 +10,7 @@
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description:
         'Rule to enforce matching htmlFor and id on FormField and its child input, respectively',

diff --git a/lib/rules/formfield-name.js b/lib/rules/formfield-name.js
@@ -10,6 +10,7 @@
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Rule to enforce name on FormField and its child input',
       category: 'Best Practices',

diff --git a/lib/rules/formfield-prefer-children.js b/lib/rules/formfield-prefer-children.js
@@ -10,6 +10,7 @@
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description:
         'Recommend use of children with FormField as opposed to component property',
@@ -22,7 +23,6 @@ module.exports = {
       'formfield-prefer-children': `It is not recommended to use the 'component' property. Instead, 
       implement the input as a child of FormField.`,
     },
-    type: 'suggestion',
   },
 
   create: function (context) {