Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resize delay causing potential error msg #1552

Merged
merged 1 commit into from
Jan 3, 2021
Merged

fix resize delay causing potential error msg #1552

merged 1 commit into from
Jan 3, 2021

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Jan 3, 2021

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
fix resize delay causing potential error msg
2d47710 
* fix gridstack#1546
* re-wrote rhlin resize code to no longer do a delay in adding move and up events.
not sure why he had 100ms + 300ms delays causing race conditions...
* also fixed so we clean up correctly
* also resize won't happen unless you move 3 pix now (was 1)
@adumesny adumesny merged commit e46df91 into gridstack:develop Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Cannot destructure property 'clientX' of 't' as it is undefined
1 participant
@adumesny