Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Cannot destructure property 'clientX' of 't' as it is undefined #1546

Closed
minhhungit opened this issue Dec 31, 2020 · 10 comments · Fixed by #1552
Closed

Issue Cannot destructure property 'clientX' of 't' as it is undefined #1546

minhhungit opened this issue Dec 31, 2020 · 10 comments · Fixed by #1552

Comments

@minhhungit
Copy link

Hello team,
The error appear when we drag widget item by fast click and throw mouse

Error message

Uncaught TypeError: Cannot destructure property 'clientX' of 't' as it is undefined.
    at i._hasMoved (dd-resizable-handle.ts:106)
    at i._mouseMove (dd-resizable-handle.ts:80)

Attached gif image to reproduce

drag-error1

@minhhungit
Copy link
Author

Or we can reproduce it by left-click one time on the drag icon (don't hold the click), drag mouse and left click again.
Sometime it will throw error

@minhhungit
Copy link
Author

more gif

drag-error-reproduce

adumesny added a commit to adumesny/gridstack.js that referenced this issue Jan 3, 2021
* fix gridstack#1546
* re-wrote rhlin resize code to no longer do a delay in adding move and up events.
not sure why he had 100ms + 300ms delays causing race conditions...
* also fixed so we clean up correctly
* also resize won't happen unless you move 3 pix now (was 1)
adumesny added a commit to adumesny/gridstack.js that referenced this issue Jan 3, 2021
* fix gridstack#1546
* re-wrote rhlin resize code to no longer do a delay in adding move and up events.
not sure why he had 100ms + 300ms delays causing race conditions...
* also fixed so we clean up correctly
* also resize won't happen unless you move 3 pix now (was 1)
@adumesny
Copy link
Member

adumesny commented Jan 3, 2021

fixed in next 3.1.3 release. Don't forget to contribute, especially since you are selling dashboard based on my code...

@minhhungit
Copy link
Author

Thank you for your fixing @adumesny, I'm still new on this library so still lack of knowledge. I will try to contribute in future !

One more question, like you said I am going to sell dashboard feature which is using gridstack as core, I want to ask if I can do it or any requirements I need to complete, thank you and happy new year !

Jin

@minhhungit
Copy link
Author

Hi @adumesny I'm trying to donate gridstack as promise but pay.pal fee is too high, donate 10$ but take ~5$ fee (~50%), is there another way to donate like "buy me a coffee". I also see "venmo" donate link but it also does not work for me. Thank you

@minhhungit
Copy link
Author

image

@adumesny
Copy link
Member

you should be able to done as gift/friend in paypal which has no fees (other than conversion fees ?) if linked to your bank accound (instead of credit card). I'm not familiar how it works from overseas.
Usually I recommend venmo (owned by paypal) as they do no have fees (here is the USA at least) as it's between friends.

@minhhungit
Copy link
Author

@adumesny See, it's 5$ pay.pal fee, also I am not USA I can not registry a venmo account

Can you please create new donate account like "buy me a coffee" or "ko-fi" I guess it's easier for global users

image

@adumesny
Copy link
Member

adumesny commented Jun 16, 2021

what do you mean by: new donate account like "buy me a coffee"
you mean another paypal account ? not sure how it would be different and if I can can create multiple accounts to my name/bank. Let me research oversea fees, as I had others have issues as well (though it wasn't fixed $5 which seems steep).

might be best to use slack for chatting...

@adumesny
Copy link
Member

adumesny commented Oct 1, 2023

@minhhungit I've added github sponsor - so yet another way to donate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants