-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Removed tss-react and replaced it with the default "styled" styling of mui. #1871
Conversation
Hey @wdh2100 buddy, please let me know if there are any changes or issues with the PR. Would be happy to resolve them. |
I have connected the repo to my project and everything worked great. If anyone can connect this PR to their project and check whether there are any issues with the PR, that would be great. |
Closing this PR. As tss-react seems to better option than the styled for readability and understanding as we update the project. |
Is this why createTheme only works for me in V4.0.0 and not anything newer? It seems createTheme from @mui/material only themes html elements without tss prepended when i use any new version. I just now figured out today that the latest version was causing my custom mui themes to not apply fully (some things would work, but not others). Is the only solution right now to stay on V4.0.0? |
deleted as misleading |
@garronej can you provide a codesandbox or equivalent of both Here's a start that I was experimenting with, if I change mui-datatables to v4, the table cells show up pink. |
deleted as misleading |
Unfortunately the docs on this repo say that you can use mui's global overrides/themes to style it's components. The example you provided is just using a class to style something conditionally and not a global theme. The codesandbox I gave you above works for v4 (before tss-react) and now fails and and I'm assuming it's because mui/tss-react don't share a global theme or something similar. Either way, it's very unfortunate that this functionality was broken after swapping to tss-react. |
@d0lb33 @hornandrewm Sorry for my previous messages, they where misleading. It's fixed in the PR #1882. |
Replaced all of the components with the
styled
styling in mui.Updated the examples with the new
styled
styling.Removed tss-react from deps.
For this issue #1826