-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @mui/styles according to migration from mui v4 to v5 #1826
Comments
Up |
@zxhmike @wdh2100 @ashfaqnisar can you take a look to this |
Hey @Fullbusters, I tried the codemod provided by mui and was able to switch most of the jss styles to styled components but it was not able to do the conversion for some of the files. |
hey @ashfaqnisar, codemod not switching all things that needed, and they not remove |
@Fullbusters Do we know if the conversion away from utilizing |
@liamlows until recently, I hoped that someone would do it, but I will have to ( |
@mui/styles will be deprecated in mui v6 you can read about this here mui/material-ui#26571
And even in guide migration from v4 to v5 exist steps for removing @mui/styles from the project here: https://mui.com/guides/migration-v4/#migrate-from-jss
I was faced with an issue that mui-datatables still used @mui/styles and I can't remove it from the project.
Think that it's a bug, because:
In my opinion, it`s should be migrated from @mui/styles as soon as possible.
Mui 5 provide for us two ways to remove it: https://mui.com/guides/migration-v4/#migrate-from-jss
But the most similar as makeStyles is this: https://dev.to/atonchev/material-ui-5-the-easiest-way-to-migrate-from-makestyles-to-emotion-1i9l
The fastest solution is to add @mui/styles to peerDependency #1820 that allow for devs to remove @mui/styles from their projects, and then step by step doing a migration from @mui/styles to emotion.
The text was updated successfully, but these errors were encountered: