-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7636 Remove editor sidebar labels uppercase #2409
Conversation
/unhold cb0b5fcf-172c-46de-9705-1a785ef6f3f6
Test instance is ready 🚀🌑 telesto | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.10.15 15:09:38 |
c6c314d
to
7b24d64
Compare
/unhold 6b9fa241-e49e-4989-a700-093d81642f96
We don't want this style to be applied
7b24d64
to
4a88399
Compare
/unhold 805d524c-3421-4c8d-91ef-125909992457
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mleray
I think this could be easily fixed by overriding the text-transform
attribute of the .css-1v57ksj
class.
Some other users complain about this issue, but using uppercase seems to be part of the WordPress styles guide.
Thanks @mardelnet, you're right that should solve it for the text components, for the select components it seems it's |
You're right, there is more than just one class to be changed. .components-base-control__field label {
text-transform: none !important;
} |
@mardelnet that's actually what I implemented at first, and it does work, I just wanted to avoid using |
Normally, I'd try to avoid using |
Closing this PR in favour of this new one. |
Description
See PLANET-7636
Testing
Make sure all labels in the editor sidebar are no longer in uppercase, and all look the same. Please test all post types since they have different sidebar fields.