Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7636 Remove editor sidebar labels uppercase #2409

Closed
wants to merge 1 commit into from

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Oct 15, 2024

Description

See PLANET-7636

Testing

Make sure all labels in the editor sidebar are no longer in uppercase, and all look the same. Please test all post types since they have different sidebar fields.

@mleray mleray self-assigned this Oct 15, 2024
planet-4 added a commit to greenpeace/planet4-test-telesto that referenced this pull request Oct 15, 2024
/unhold cb0b5fcf-172c-46de-9705-1a785ef6f3f6
@planet-4
Copy link
Contributor

planet-4 commented Oct 15, 2024

Test instance is ready 🚀

🌑 telesto | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.10.15 15:09:38

@mleray mleray force-pushed the fix-editor-labels-uppercase branch from c6c314d to 7b24d64 Compare October 15, 2024 14:43
planet-4 added a commit to greenpeace/planet4-test-telesto that referenced this pull request Oct 15, 2024
/unhold 6b9fa241-e49e-4989-a700-093d81642f96
@mleray mleray added the Review label Oct 15, 2024
@mleray mleray marked this pull request as ready for review October 15, 2024 14:46
@mleray mleray requested review from a team, sagarsdeshmukh and GP-Dan-Tovbein and removed request for a team October 15, 2024 14:46
We don't want this style to be applied
@mleray mleray force-pushed the fix-editor-labels-uppercase branch from 7b24d64 to 4a88399 Compare October 15, 2024 15:00
planet-4 added a commit to greenpeace/planet4-test-telesto that referenced this pull request Oct 15, 2024
/unhold 805d524c-3421-4c8d-91ef-125909992457
Copy link
Contributor

@mardelnet mardelnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mleray
I think this could be easily fixed by overriding the text-transform attribute of the .css-1v57ksj class.
Some other users complain about this issue, but using uppercase seems to be part of the WordPress styles guide.

@mleray
Copy link
Contributor Author

mleray commented Oct 16, 2024

css-1v57ksj

Thanks @mardelnet, you're right that should solve it for the text components, for the select components it seems it's .css-12g1mba.css-12g1mba.css-12g1mba. I just find these class names annoying, not clear at all 😬 And I'm wondering how often WordPress changes them.

@mardelnet
Copy link
Contributor

Thanks @mardelnet, you're right that should solve it for the text components, for the select components it seems it's .css-12g1mba.css-12g1mba.css-12g1mba. I just find these class names annoying, not clear at all 😬 And I'm wondering how often WordPress changes them.

You're right, there is more than just one class to be changed.
What about using a more generic selector with !important?
I did not test it, but maybe something like:

.components-base-control__field label {
  text-transform: none !important;
}

@mleray
Copy link
Contributor Author

mleray commented Oct 16, 2024

.components-base-control__field label {
  text-transform: none !important;
}

@mardelnet that's actually what I implemented at first, and it does work, I just wanted to avoid using !important... Do you think it would be better in this case?

@mardelnet
Copy link
Contributor

@mardelnet that's actually what I implemented at first, and it does work, I just wanted to avoid using !important... Do you think it would be better in this case?

Normally, I'd try to avoid using !important, but in this case, we have to edit three JS and one CSS file to get the same result, so I think it's worth it.

@mleray
Copy link
Contributor Author

mleray commented Oct 16, 2024

Closing this PR in favour of this new one.

@mleray mleray closed this Oct 16, 2024
@mleray mleray deleted the fix-editor-labels-uppercase branch October 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants