-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Update control labels to the new uppercase styles #42782
Comments
I know there are different research results and opinions, but has there at least been a discussion about the use of all caps and readability impact before this proposed change is merged? |
Good question! First off, I assume the intent is to aid the user in perceiving the information hierarchy more easily by adding more visual differentiation. And labels are pretty short by nature, so I don't think it'll get to the point where readability is clearly harmed. Just my opinion though. Given that we're decreasing the font-size to 11px, I would actually be more concerned about non-Latin characters, especially those that don't have uppercase. For example, readability issues can start to creep up with CJK characters earlier than uppercased Latin characters. But the codebase already contains a good number of label-like text at 11px (but no smaller), so I guess that's kind of like our de facto lower bound. @pablohoneyhoney has been leading the redesign, I'll defer to him for more in-depth reasoning. (cc @WordPress/gutenberg-design) |
It's been a week so we're going to be merging this for now. But if folks wants to continue this discussion, I just wanted to note that the label styles will be very easy to change moving forward, thanks to the refactor. |
I believe this change has caused a problem for the Jetpack Consent block. |
@bobbingwide Hi there! I'm not sure what the Jetpack Consent block is, but based on the screenshot you posted in #34345 (comment), it looks like multiple things are wrong with the block's implementation. For example, the "By submitting your information..." text is too long and inappropriate for something to put in a |
@mirka The problem is that the text in the BTW: I've since found more blocks that have been adversely affected by this change. |
Yes, the thing is that the component labels we uppercased are not intended to be used as text entry fields, and even when they are for some reason, those
Good to know! If you could post some links to their code we could perhaps give better guidance on usage. |
The control labels need to be updated to the new uppercase styles:
The text was updated successfully, but these errors were encountered: