Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeship CI Integration #72

Merged
merged 21 commits into from
Jan 19, 2018
Merged

Conversation

selbyk
Copy link
Contributor

@selbyk selbyk commented Oct 10, 2017

Implements support for Codeship Pro, updates lockfile on commit messages matching /^(chore|fix)\(package\): update [^ ]+ to version.*$/mi

#25

@selbyk selbyk mentioned this pull request Oct 10, 2017
3 tasks
Copy link
Contributor

@janl janl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work, just one question: why the limit to certain commit prefixes? We don’t do that for other CI environments. This should be usable without semantic-release, if that’s what you’re going for.

@StephanBijzitter
Copy link

@janl Since the author is not responding and we also really want this feature:

Codeship does not provide any information that is used by this package on other services to detect the state of the branch. There's only one way to know whether Greenkeeper has already commited on a branch to then update the lockfile and that is by parsing the commit message.

This change does indeed limit Greenkeeper to stick to a specific pattern for commit messages, but that's really the only limitation introduced by this pull request. Even then, if users are (in the future) able to customise these messages, it could simply ignore the customisation on Codeship and stick to the default pattern.

@selbyk
Copy link
Contributor Author

selbyk commented Dec 21, 2017

@janl Sorry for the delayed response, but this has been put on the backburner for the past month or so. I initially tried using the techniques used in the other CI implementations, but gitHelpers.getNumberOfCommitsOnBranch was sporadically returning an incorrect value for some reason. I'm not actually sure what correctBuild should be a switch for, but Codeship doesn't have an environment variable exposed saying wether a build represents a PR, like I see some other implementations doing.

Can you clarify what being usable without semantic-release means? I'd be happy to make adjustments where necessary to get this merged in, but we've been using it in the current state for a couple months now.

@janl
Copy link
Contributor

janl commented Jan 19, 2018

Thanks for the explanation

@Realtin
Copy link
Member

Realtin commented Jan 19, 2018

Thank you @selbyk for your work and @StephanBijzitter for the explanation ✨ 🌴

@Realtin Realtin merged commit 258e9c0 into greenkeeperio:master Jan 19, 2018
@Realtin
Copy link
Member

Realtin commented Jan 19, 2018

Oh no! I squashed the commits and now it's all under my name. I'm so sorry 😢

@StephanBijzitter
Copy link

StephanBijzitter commented Jan 19, 2018

@selbyk committed with @Realtin feat: add basic Codeship CI Integration

Looks good to me ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants