-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Codeship support #25
Comments
Hey @StephanBijzitter, if you want to tackle this I'm more than happy to assist you with it. You're todo list looks exactly right though :) Let me know how it goes. Looking forward to your PR 👍 Best, |
Started working on it already! Codeship does not seem to have as much information about pull requests immediately available through environment variables (as compared to Travis), so I'll have to resort to parsing the result of the command-line. The way this repository is set up is definitely very nice! Progress can be seen in my fork, and I'll migrate that pull request to this repository when it's finished. |
Any update on your PR? I see Codeship are still working on the |
Yeah it turned out to be more tricky than anticipated, so I moved it to our backlog. Good news though, because I (or someone in my team) will pick this up soon. Of course all help is welcome, but I think we'll able to fit this into the next sprint, or the one after that. |
I opened a PR that we have been using for about a month: #72 |
Closing in favour of #72 |
Hey, there - a bit late, but I wanted to let y'all know that we now have this environment variable exposed on Codeship. :) |
Not sure if this is being worked on already, which is why I'm creating this issue.
Looking at the source, this is what will have to be done:
An entry must be added to
tests.js
to test for Codeshiphttps://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/ci-services/tests.js
A file
codeship.js
needs to be created to take the correct environment variables from codeship.https://github.com/greenkeeperio/greenkeeper-lockfile/blob/master/ci-services/travis.js
Because Codeship does not provide enough information (for performance reasons), hacky workarounds need to be tested very carefully.
If this is all, I'll be able to do this sometime this week.
The text was updated successfully, but these errors were encountered: