Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update structure and content of diagnostics section #1076

Merged
merged 25 commits into from
Jan 6, 2022

Conversation

jessegmeyerlab
Copy link
Contributor

@jessegmeyerlab jessegmeyerlab commented Dec 29, 2021

Description of the proposed additions or changes

Minor rewordings and paragraph structure changes in intro, and divided molecular tests into nucleic acid tests and protein tests (e.g. the abbott at-home rapid tests based on lateral flow). Added section on RT-LAMP detection of nucleic acids.

Looking forward to your feedback. Thanks for making this open for anyone to contribute!

Related issues

#1075

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

break up long intro paragraphs, shortened wording, and added information including citation
add subsection for sequencing and LFTs
added section on RT LAMP with one review cited and one recent study cited. Also added a section on lateral flow tests as to-do. Will need to add more examples of both. Also changed some organization and formatting, for example moved sequencing to its own section, which was previously part of the intro to molecular tests section.
@AppVeyorBot
Copy link

AppVeyor build 1.0.4723 for commit 67eddfc is now complete.

Found 17 potential spelling error(s). Preview:content/10.diagnostics.md:21:LFT
content/10.diagnostics.md:28:baccines
content/10.diagnostics.md:47:LFT
content/10.diagnostics.md:123:thermocycler
content/10.diagnostics.md:124:cycler
content/10.diagnostics.md:125:detecion
content/10.diagnostics.md:127:sensitity
content/10.diagnostics.md:134:benchmarked
content/10.diagnostics.md:137:Biolabs
content/10.diagnostics.md:137:WarmStart
content/10.diagnostics.md:138:IVT
content/...
The rendered manuscript from this build is temporarily available for download at:

added minimum of LFT section under molecular tests, minor edits elsewhere
@AppVeyorBot
Copy link

AppVeyor build 1.0.4724 for commit 98229e0 is now complete.

Found 24 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:Biolabs
content/10.diagnostics.md:138:WarmStart
content/10.diagnostics.md:139:IVT
content/10...
The rendered manuscript from this build is temporarily available for download at:

@agitter
Copy link
Collaborator

agitter commented Dec 31, 2021

Thanks for the edits @jessegmeyerlab. We'll likely review this and give feedback next week. You can tag me if you run into any issues with Manubot.

Copy link
Collaborator

@RLordan RLordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jessegmeyerlab glad you joined! Great additions, I have made some minor suggested changes with one or two questions. However, I defer to @rando2 for approval and review of the PR. :)

content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
jessegmeyerlab and others added 11 commits January 2, 2022 14:11
Co-authored-by: Ronan Lordan <[email protected]>
Co-authored-by: Ronan Lordan <[email protected]>
Co-authored-by: Ronan Lordan <[email protected]>
Co-authored-by: Ronan Lordan <[email protected]>
@jessegmeyerlab
Copy link
Contributor Author

@RLordan thanks for taking the time to go through my suggestions! I accepted most of them and replied to a couple. What should I do next?

content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

AppVeyor build 1.0.4740 for commit b9132a1 is now complete.

Found 26 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:infective
content/10.diagnostics.md:139:Biolabs
content/10.diagnostics.md:139:WarmStart
cont...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.4741 ...

Found 25 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:infective
content/10.diagnostics.md:139:WarmStart
content/10.diagnostics.md:140:IVT
content/ for commit e3d17a8 is now complete. The rendered manuscript from this build is temporarily available for download at:

Copy link
Contributor

@rando2 rando2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @jessegmeyerlab! Would we be able to get your author info for https://github.com/greenelab/covid19-review/blob/master/content/metadata.yaml? Either edit the file and add it or just let me know and I can add it for you! It's great to have you on the team!

Thank you so much to @RLordan for taking the lead while I was out dealing with a COVID outbreak in my family (and @RLordan please feel free to merge text that you've approved in the future, ideally just check the PDF builds OK and I can always fix minor formatting issues later!)

content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
content/10.diagnostics.md Outdated Show resolved Hide resolved
@rando2
Copy link
Contributor

rando2 commented Jan 6, 2022

@RLordan I noticed your review is marked as "needs changes," so just wanted to check if the changes have been made or whether this PR is still evolving! Thank you so much again for being so on top of things!!!

@AppVeyorBot
Copy link

AppVeyor build 1.0.4745 for commit d0033d8 is now complete.

Found 32 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:infective
content/10.diagnostics.md:139:WarmStart
content/10.diagnostics.md:140:IVT
content/...
The rendered manuscript from this build is temporarily available for download at:

@RLordan
Copy link
Collaborator

RLordan commented Jan 6, 2022

This is fantastic @jessegmeyerlab! Would we be able to get your author info for https://github.com/greenelab/covid19-review/blob/master/content/metadata.yaml? Either edit the file and add it or just let me know and I can add it for you! It's great to have you on the team!

Thank you so much to @RLordan for taking the lead while I was out dealing with a COVID outbreak in my family (and @RLordan please feel free to merge text that you've approved in the future, ideally just check the PDF builds OK and I can always fix minor formatting issues later!)

Thanks @rando2, glad you are all doing well again. I think I approved the changes correctly, it should be good to go. A great addition by @jessegmeyerlab

@rando2
Copy link
Contributor

rando2 commented Jan 6, 2022

Fabulous! I will merge, @jessegmeyerlab do you mind opening a new PR to add your author info? (Or let me know and I can help!)

@jessegmeyerlab
Copy link
Contributor Author

Fabulous! I will merge, @jessegmeyerlab do you mind opening a new PR to add your author info? (Or let me know and I can help!)

Thanks for looking at this.

I'm not sure how to handle the contributions and manuscript section so can you please add how you see fit? Here is my info:

github: jessegmeyerlab
name: Jesse G. Meyer
initials: JGM
orcid: 0000-0003-2753-3926
email: [email protected]
affiliations:
  - Department of Biochemistry, Medical College of Wisconsin, Milwaukee, Wisconsin, United States of America

Let me know if you need anything else.

@AppVeyorBot
Copy link

AppVeyor build 1.0.4753 for commit 702c57d is now complete.

Found 32 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:infective
content/10.diagnostics.md:139:WarmStart
content/10.diagnostics.md:140:IVT
content/...
The rendered manuscript from this build is temporarily available for download at:

affiliations:
- Department of Biochemistry, Medical College of Wisconsin, Milwaukee, Wisconsin, United States of America
coi:
string: "None"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessegmeyerlab The only other thing I need from you is just any disclosure of conflicts of interest -- or just okay the "None" I have here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any conflicts of interest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! I'm merging it in now :)

@AppVeyorBot
Copy link

AppVeyor build 1.0.4754 for commit e0e44d5 is now complete.

Found 32 potential spelling error(s). Preview:content/10.diagnostics.md:23:LFTs
content/10.diagnostics.md:26:CLIA
content/10.diagnostics.md:26:LFIA
content/10.diagnostics.md:124:thermocycler
content/10.diagnostics.md:125:cycler
content/10.diagnostics.md:127:detecion
content/10.diagnostics.md:129:sensitity
content/10.diagnostics.md:135:benchmarked
content/10.diagnostics.md:138:infective
content/10.diagnostics.md:139:WarmStart
content/10.diagnostics.md:140:IVT
content/...
The rendered manuscript from this build is temporarily available for download at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants