Make sure modify_setting value is Base64-encoded
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server expects the text child of a `value` element in `modify_setting` to be Base64-encoded, so adjust test accordingly.
The server expects the text child of a `value` element in `modify_setting` to be Base64-encoded, so modify_setting must make sure this is the case.
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 10 10
Lines 2412 2412
=======================================
Hits 2320 2320
Misses 92 92
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server expects the text child of a
valueelement inmodify_settingto beBase64-encoded, failing to do so can have severe consequences like locking out
the user entirely. This PR ensures the correct encoding and adjusts the tests
accordingly.
Checklist: