Merge pull request #98 from wiegandm/modify_setting_value_base64

Make sure `modify_setting` value is Base64-encoded
greenbone · Feb 25, 2019 · 0a3c227 · 0a3c227
2 parents 010a71c + 0e39dc6
commit 0a3c227
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,7 @@
   `get_preference`
 * Fixed wrong order of key and value for condition_data, event_data and
   method_data dict parameters of `modify_alert` method.
+* Ensure `modify_setting` value is Base64-encoded
 
 # python-gvm 1.0.0.beta2 (04.12.2018)
 

diff --git a/gvm/protocols/gmpv7.py b/gvm/protocols/gmpv7.py
@@ -4782,7 +4782,7 @@ def modify_setting(self, setting_id=None, name=None, value=None):
         else:
             cmd.add_element('name', name)
 
-        cmd.add_element('value', value)
+        cmd.add_element('value', _to_base64(value))
 
         return self._send_xml_command(cmd)
 

diff --git a/tests/protocols/gmpv7/test_modify_setting.py b/tests/protocols/gmpv7/test_modify_setting.py
@@ -38,7 +38,7 @@ def test_modify_setting(self):
 
         self.connection.send.has_been_called_with(
             '<modify_setting setting_id="s1">'
-            '<value>bar</value>'
+            '<value>YmFy</value>'
             '</modify_setting>'
         )
 
@@ -50,7 +50,7 @@ def test_modify_setting(self):
         self.connection.send.has_been_called_with(
             '<modify_setting>'
             '<name>s1</name>'
-            '<value>bar</value>'
+            '<value>YmFy</value>'
             '</modify_setting>'
         )