Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parameters ... #185

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Dec 6, 2019

I thought this would be more consistent for all the default parameter.

Checklist:

  • Tests "N/A"
  • CHANGELOG Entry "N/A"
  • Documentation "N/A"

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #185 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   91.23%   91.24%   +0.01%     
==========================================
  Files          12       12              
  Lines        1015     1017       +2     
==========================================
+ Hits          926      928       +2     
  Misses         89       89
Impacted Files Coverage Δ
gvm/connections.py 57.32% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba692d...7569afb. Read the comment docs.

@bjoernricks bjoernricks merged commit 63ca013 into greenbone:master Dec 6, 2019
@y0urself y0urself deleted the unify-config-params branch January 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants