Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify config params #240

Merged
merged 6 commits into from
Jan 10, 2020
Merged

Unify config params #240

merged 6 commits into from
Jan 10, 2020

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Dec 6, 2019

I thought this would be more consistent for all the default parameter.
They are now all imported from the python-gvm and this pull requests is only valid in combination with greenbone/python-gvm#185

Checklist:

  • Tests
  • CHANGELOG Entry "N/A"
  • Documentation "N/A"

bjoernricks
bjoernricks previously approved these changes Dec 6, 2019
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@bjoernricks
Copy link
Contributor

We need a new minor release for python-gvm before we can merge this PR.

@bjoernricks bjoernricks self-assigned this Dec 7, 2019
@bjoernricks
Copy link
Contributor

i've released python-gvm 1.2.0 on Monday which includes the required changes. Please update the the dependencies (via pipenv update) and change https://github.com/greenbone/gvm-tools/blob/master/setup.py#L49 to python-gvm>=1.2.0 Afterwards your PR should be mergeable again.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #240 into master will decrease coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   33.41%   33.08%   -0.34%     
==========================================
  Files           6        6              
  Lines         404      402       -2     
==========================================
- Hits          135      133       -2     
  Misses        269      269
Impacted Files Coverage Δ
gvmtools/parser.py 88.88% <ø> (-0.11%) ⬇️
gvmtools/config.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07ee3cc...6349ae6. Read the comment docs.

@bjoernricks bjoernricks self-requested a review January 10, 2020 10:50
@bjoernricks bjoernricks merged commit f070194 into greenbone:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants