-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify config params #240
Unify config params #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks
We need a new minor release for python-gvm before we can merge this PR. |
i've released python-gvm 1.2.0 on Monday which includes the required changes. Please update the the dependencies (via pipenv update) and change https://github.com/greenbone/gvm-tools/blob/master/setup.py#L49 to python-gvm>=1.2.0 Afterwards your PR should be mergeable again. |
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
- Coverage 33.41% 33.08% -0.34%
==========================================
Files 6 6
Lines 404 402 -2
==========================================
- Hits 135 133 -2
Misses 269 269
Continue to review full report at Codecov.
|
I thought this would be more consistent for all the default parameter.
They are now all imported from the
python-gvm
and this pull requests is only valid in combination with greenbone/python-gvm#185Checklist: