-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create extended severities object #192
Create extended severities object #192
Conversation
89e2a69
to
584a2a0
Compare
584a2a0
to
fd0f39a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks okay, but the expected test output for test_get_severities_xml
of tests/test_daemon.py
needs to be adjusted.
This is about the given values we might have at hand. It is not yet considering multiple severities from a NVT though. But if the internal severity structure has a origin or date, then it will be considered already.
fd0f39a
to
f4ab2e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 84.39% 84.51% +0.11%
==========================================
Files 9 9
Lines 1493 1498 +5
==========================================
+ Hits 1260 1266 +6
+ Misses 233 232 -1
Continue to review full report at Codecov.
|
Extend get_scans OSPd cmd with max_results argument.
This is about the given values we might have at hand.
It is not yet considering multiple severities from a NVT though.
But if the internal severity structure has a origin or date,
then it will be considered already.