Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extended severities object #192

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

janowagner
Copy link
Member

This is about the given values we might have at hand.
It is not yet considering multiple severities from a NVT though.
But if the internal severity structure has a origin or date,
then it will be considered already.

@mattmundell mattmundell changed the title Create extended severities object. Create extended severities object Oct 13, 2020
@mattmundell mattmundell marked this pull request as ready for review October 13, 2020 15:39
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks okay, but the expected test output for test_get_severities_xml of tests/test_daemon.py needs to be adjusted.

janowagner and others added 3 commits October 15, 2020 03:48
This is about the given values we might have at hand.
It is not yet considering multiple severities from a NVT though.
But if the internal severity structure has a origin or date,
then it will be considered already.
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   84.39%   84.51%   +0.11%     
==========================================
  Files           9        9              
  Lines        1493     1498       +5     
==========================================
+ Hits         1260     1266       +6     
+ Misses        233      232       -1     
Impacted Files Coverage Δ
ospd_openvas/daemon.py 68.15% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2292d6...f4ab2e6. Read the comment docs.

@timopollmeier timopollmeier merged commit 83c525c into greenbone:master Oct 15, 2020
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Extend get_scans OSPd cmd with max_results argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants