Fix isotime_add and add zero padding for isotime #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size of 19 was introduced with f85dbd3. PR: greenbone#252 This broke the nasl_isotime_add function.
When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes.
ArnoStiefvater
force-pushed
the
fix-isotime-add
branch
from
0bc10ec
to
5171afb
Compare
jjnicola
approved these changes
Nov 1, 2021
y0urself
approved these changes
Nov 2, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf)
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Size of 19 for ISOTIME_SIZE was introduced with f85dbd3. PR: #252
This broke the nasl_isotime_add function.
When time in the format like '869-10-02 12:34' or
'869-10-02 12' was given to string2isotime() the
function did not fill up the missing seconds and
minutes with zeroes.
Jira: SC-455
Why:
How:
Run
nasl/tests/test_isotime.nasl. E.g.openvas-nasl -X -t 127.0.0.1 test_isotime.naslChecklist: