avoid unitialized access in nasl parsing #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 31.13% 31.13%
=======================================
Files 133 133
Lines 2505 2505
=======================================
Hits 780 780
Misses 1725 1725
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 31.92% 31.92%
=======================================
Files 133 133
Lines 2500 2500
=======================================
Hits 798 798
Misses 1702 1702
Continue to review full report at Codecov.
|
|
Sorry, cant fill file with 10 char extra comments. |
kroosec
approved these changes
Feb 6, 2019
ArnoStiefvater
added a commit
to ArnoStiefvater/openvas
that referenced
this pull request
Nov 1, 2021
Size of 19 was introduced with f85dbd3. PR: greenbone#252 This broke the nasl_isotime_add function.
2 tasks
ArnoStiefvater
added a commit
to ArnoStiefvater/openvas
that referenced
this pull request
Nov 1, 2021
Size of 19 was introduced with f85dbd3. PR: greenbone#252 This broke the nasl_isotime_add function.
y0urself
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf)
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf)
y0urself
pushed a commit
that referenced
this pull request
Nov 2, 2021
…backport) * Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf) Co-authored-by: ArnoStiefvater <[email protected]>
y0urself
pushed a commit
that referenced
this pull request
Nov 2, 2021
…backport) * Add nasl log domain * Revert `ISOTIME_SIZE` from 19 to 16 Size of 19 was introduced with f85dbd3. PR: #252 This broke the nasl_isotime_add function. * Add zero values at end of iso time When time in the format like '869-10-02 12:34' or '869-10-02 12' was given to string2isotime() the function did not fill up the missing seconds and minutes with zeroes. * Fix formatting (cherry picked from commit e7f4daf) Co-authored-by: ArnoStiefvater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.