Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for source_iface settings which will be removed with 21.10 release #732

Merged

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented May 12, 2021

What:

Add deprecation warning for source_iface settings which will be removed with 21.10 release.

related: #730

Why:

To warn users about upcoming changes.

How:

Add options sys_ifaces_allow and sys_ifaces_deny to the openvas conf file and start a small scan via gvm-cli with options:

    <scanner_params>\
        <source_iface>enp0s8</source_iface>\
        <ifaces_deny>enp0s8</ifaces_deny>\
        <ifaces_allow>foo</ifaces_allow>\
    </scanner_params>\

In the results the following error result will appear: The following provided settings are deprecated and will be ignored starting with the upcoming release 21.10: source_iface (task setting) ifaces_ allow (user setting) ifaces_deny (user setting) sys_ifaces_allow (scanner only setting)sys_ifaces_deny (scanner only setting)

The scan will stop in the interruped status with the above test.

Checklist:

It is done in attack.c so we can easily
send an erro message to the client.
@ArnoStiefvater ArnoStiefvater requested a review from a team May 12, 2021 07:30
@jjnicola jjnicola merged commit e4683f1 into greenbone:openvas-21.04 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants