Remove source iface preferences #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ArnoStiefvater
force-pushed
the
remove_source_iface
branch
2 times, most recently
from
365ad32
to
5fcbd7b
Compare
Remove handling of `source_iface` setting and related settings `ifaces_deny`, `ifaces_allow`, `sys_ifaces_deny` and `sys_ifaces_allow` on scanner side. Standalone NASL interpreter can still handle `source_iface` preference for now.
It is done in attack.c so we can easily send an erro message to the client.
ArnoStiefvater
force-pushed
the
remove_source_iface
branch
from
5fcbd7b
to
afdd160
Compare
Merged
2 tasks
jjnicola
requested changes
May 12, 2021
src/attack.c
Outdated
| * | ||
| * @return True if deprecated prefs are in preference table. Else False. | ||
| */ | ||
| gboolean |
There was a problem hiding this comment.
Shouldn't this be static? Shouldn't be just a void function? the return value is not used, and the message is sent directly from the function.
jjnicola
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove source iface preferences.
source_iface preferences can still be set for nasl standalone for development purposes.
Why:
Remove rarely used option.
How:
Add options sys_ifaces_allow and sys_ifaces_deny to the openvas conf file and start a small scan via gvm-cli with options:
In the results the following error result will appear:
The following provided settings are deprecated since the 21.10 release and will be ignored: source_iface (task setting) ifaces_ allow (user setting) ifaces_deny (user setting) sys_ifaces_allow (scanner only setting)sys_ifaces_deny (scanner only setting)Checklist: