Improve nasl linter #728
Merged
Improve nasl linter #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch things like `if(!get_port_state(foostateport)){}`
by resetting `defined_var_mode` when setting `defined_fn_mode`.
Variables declared in foreach call are now considered local variables if there are already local variables present.
exec_nasl_script now returns the number of errors the linter finds if no none linting errors occure.
jjnicola
approved these changes
May 7, 2021
ArnoStiefvater
added a commit
that referenced
this pull request
May 11, 2021
Improve nasl linter (backport #728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improve linter to catch more undeclared variables.
Imporve linter to continue linting if undeclared variables are detected. More than 1 error can now be logged for a single script.
jira: SC-163
Why:
Improvement.
How:
Checklist: