Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case sensitive linting #1079

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

Kraemii
Copy link
Member

@Kraemii Kraemii commented Apr 5, 2022

What:
This PR reverts some changes from #728, to be exact the changes from the commit f123713.
SC-584

Why:
The nasl linter was not able to detect undeclared variables in case of different letter cases, e.g. for the linter cpe and CPE was the same variable name even though it is not.

How:
Run openvas-nasl-lint test.nasl before and after with this small script:

CPE = "foo";
display(cpe);
exit(0);

Checklist:

  • Tests
  • PR merge commit message adjusted

@Kraemii Kraemii requested a review from a team as a code owner April 5, 2022 11:56
@Kraemii Kraemii enabled auto-merge (squash) April 5, 2022 11:57
@Kraemii Kraemii merged commit 2481d17 into greenbone:main Apr 12, 2022
mergify bot pushed a commit that referenced this pull request Apr 12, 2022
(cherry picked from commit 2481d17)
ArnoStiefvater pushed a commit that referenced this pull request Apr 14, 2022
(cherry picked from commit 2481d17)

Co-authored-by: Christoph Krämer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants