Fix "Start Task" alerts by using alert owner #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When alerts using this method are triggered outside the test_alert GMP command the user running the start_task command may be NULL, causing problems in the GMP handling process.
This makes it so the alert owner needs to have permissions for the task for the alert to work.
timopollmeier
changed the title
mattmundell
approved these changes
Jan 28, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When alerts using this method are triggered outside the test_alert GMP
command the user running the start_task command may be NULL, causing
problems in the GMP handling process.
Checklist: