Add option for "Start task" on "new secinfo arrived" for alerts #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #2419 +/- ##
=============================================
+ Coverage 52.76% 52.93% +0.16%
=============================================
Files 1070 1070
Lines 25789 25831 +42
Branches 7312 7358 +46
=============================================
+ Hits 13607 13673 +66
+ Misses 11058 11039 -19
+ Partials 1124 1119 -5
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
There is the new alerts feature of starting a task upon the arrival of new secinfo. gvmd has it implemented in greenbone/gvmd#957 and greenbone/gvmd#960. This PR adds the start task option to the corresponding method selection.
Why:
Without these changes, the new feature would not be available in GSA.
How:
The "Start Task" event is pushed into the list of possible methods. From this list I chose the 'Start task' together with the secinfo event condition and clicked on "test alert". The corresponding task started.
Checklist: