-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all NVT preference names are in the new format #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my test run there were several timeout entries in nvt_preferences that were not replaced by the migrator.
The migrator or maybe the part of manage_update_nvt_cache_osp
that calls check_preference_names
should rename preferences like [...]:entry:timeout
to [...]:0:entry:timeout
(inserting the id :0
).
We already assume that the timeout has the id 0 elsewhere, so it should be okay.
I think updating the timeouts near the start of the migrator would be the best place to prevent warnings about unknown preference names.
Should be solved by b594763. |
And with b594763 there should no longer be unknown preferences (both old or new format) in nvt_preferences after the first sync. |
This uses a hardcoded list of NVT preference names to ensure that all
NVT preferences that are in the form OID:TYPE:NAME are converted
to the form OID:ID:TYPE:NAME.
OID:TYPE:NAME was the result of migrate_205_to_206 from #394. Here
we introduce migrate_219_to_220.
The OID:ID:TYPE:NAME format was introduced in /pull/413.
Checklist: