Fix: Use right case for NVT timeout preference #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
mattmundell
changed the title
mattmundell
changed the title
mattmundell
changed the title
mattmundell
changed the title
timopollmeier
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use lowercase "timeout" when matching the timeout preference in
init_nvt_preference_iteratorandnvt_default_timeout.Why
OSP uses lowercase for this preference. The capitalization is left over from OTP.
To reproduce, in GSA edit a config, edit the family "Product detection" and then edit the NVT "Eggdrop detection" (OID 1.3.6.1.4.1.25623.1.0.100206). Before the PR there was an extra Timeout preference, and the special Timeout preference in the top row was missing the default value (3600).
References
The timeout prefs in the db were updated to lowercase in 2019 in b594763 as part of /pull/744.