Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for starting a otp scan (multiple commits) #623

Merged
merged 6 commits into from
Jun 28, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jun 26, 2019

Same as Jan's #608 but using multiple commits so that reviewers can read it.

I compared this manage.c and the manage.c from 608 and they are the same.

Here's the description from 608:

In run_task(), do not call anymore run_otp_task() as fall-though
for non-matching scanner type (not the case anyway).
Instead return a error code in case of an unknown scanner type.

Subsequently remove the now-unsed function run_otp_task().
And further delete all functions that become usused by this.

The diff looks complicated, but actually it is only changing
run_task() and other than that simply remove entire functions.

@mattmundell mattmundell requested a review from a team June 26, 2019 07:52
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much easier to read. I already did some test runs with #608 and after having a clearer look at the changes it still looks good to me.

@timopollmeier timopollmeier merged commit f97d4a6 into greenbone:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants