Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for starting a otp scan. #608

Closed
wants to merge 1 commit into from

Conversation

janowagner
Copy link
Member

@janowagner janowagner commented Jun 19, 2019

In run_task(), do not call anymore run_otp_task() as fall-though
for non-matching scanner type (not the case anyway).
Instead return a error code in case of an unknown scanner type.

Subsequently remove the now-unsed function run_otp_task().
And further delete all functions that become usused by this.

The diff looks complicated, but actually it is only changing
run_task() and other than that simply remove entire functions.

timopollmeier
timopollmeier previously approved these changes Jun 20, 2019
@mattmundell
Copy link
Contributor

Really hard to see what is changing here.

Also, I would expect a much more drastic impact from removing the running
of OTP tasks. A lot of the complications in the gvmd.c select loop are to
support listening to the OTP scanner while also handling GMP input, if I
remember right.

@janowagner
Copy link
Member Author

Also, I would expect a much more drastic impact from removing the running
of OTP tasks. A lot of the complications in the gvmd.c select loop are to
support listening to the OTP scanner while also handling GMP input, if I
remember right.

Thats true and why I called it "remove code for starting...".
Since this diff was already a bit hard to read, I wanted to have separate PRs
for removing the code that handles a running OTP scan.

In run_task(), do not call anymore run_otp_task() as fall-though
for non-matching scanner type (not the case anyway).
Instead return a error code in case of an unknown scanner type.

Subsequently remove the now-unsed function run_otp_task().
And further delete all functions that become usused by this.

The diff looks complicated, but actually it is onl changing
run_task() and other than that remove entire functions.
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added #623 because I couldn't follow this patch. Please can we merge that one instead?

@timopollmeier timopollmeier added the duplicate This issue or pull request already exists label Jun 28, 2019
@timopollmeier
Copy link
Member

I've reviewed and merged #623, so I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants