Fix whole-only config family selection #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When modifying the family selection of a scan config, "whole-only" must be either growing with all VTs or static and empty. The error message if this is not the case now also includes the name of the (first) rejected family.
timopollmeier
added
the
backport-to-main
3 tasks
nichtsfrei
approved these changes
May 14, 2021
nichtsfrei
added a commit
that referenced
this pull request
May 14, 2021
Fix whole-only config family selection (backport #1517)
|
Hi Any news on when this might be resolved? Thanks |
|
It is resolved. The patch is in the 21.04 branch. Are you waiting for a release? |
|
Im running version 21.04.0 Not sure on how to patch this issue? |
|
So I guess you are using some disto packages. In that case we can't do very much for you besides doing a new release https://community.greenbone.net/t/frequently-asked-questions-faq/5558#heading--update-my-gvm-version |
|
So i this resolved on this GVM OS? When will there be a new release? Thanks for the info btw |
|
Yes this should be fixed in our GSM products already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
When modifying the family selection of a scan config, "whole-only" must
be either growing with all VTs or static and empty.
The error message if this is not the case now also includes the name of
the (first) rejected family.
Why:
This selection should ensure that these special families are either selected
completely or not at all and the growing/static ensures they stay that way
if new NVTs are added.
How did you test it:
By modifying a config in GSA to include some of the "whole-only" LSC families
and exclude others.
With greenbone/gsa#2905 the config should be accepted, without the changes
there should be an error message for the first unselected "whole-only" family.
Checklist: