Fix changing Trend and Select for NVT-families and whole selection only #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-21.04 #2905 +/- ##
==========================================
Coverage 53.83% 53.84%
==========================================
Files 1075 1075
Lines 26226 26250 +24
Branches 7491 7506 +15
==========================================
+ Hits 14118 14133 +15
- Misses 10993 11000 +7
- Partials 1115 1117 +2
Continue to review full report at Codecov.
|
swaterkamp
force-pushed
the
wholeFamilyTrendSelect
branch
from
5e8ddb8
to
f8d79d3
Compare
2 tasks
sarahd93
approved these changes
May 11, 2021
This was referenced May 12, 2021
Merged
saberlynx
added a commit
that referenced
this pull request
May 12, 2021
Fix changing Trend and Select for NVT-families and whole selection only (backport #2905)
saberlynx
added a commit
that referenced
this pull request
May 12, 2021
Fix changing Trend and Select for NVT-families and whole selection only (backport #2905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Automatically send trend:0 (static) when a whole-selection only family is unselected.
Needs greenbone/gvmd#1517
Why:
gvmd needs an explicit trend:0 with an unselected whole-selection family
How:
Observe automatic radio button changes when selecting/unselecting a whole-selection family, verify that the old behavior still works for all other families (no automatic changes), and check parameters in network request.
Checklist: