Ignore min_qod when getting single results by UUID #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the default min_qod being applied to selections by UUID, thus hiding the result if its QoD was lower. This error was introduced in c9dc67a. Before this special filter options like min_qod were simply ignored by init_get_iterator2_with when getting single results.
bjoernricks
approved these changes
Aug 27, 2020
2 tasks
|
Doesn't this change the behaviour of GET_RESULTS from gvmd <20.08 though? In gvmd <20.08 there was no extra_where_single arg for init_get_iterator2_with, so none of the filtering would reach the SQL when an id was given. This was consistent with the other types, that ignore the filter when an id is given, for example
does not return an empty response when the target's name is 'def'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Prevents results being hidden by implicit or explicit min_qod filters when selecting results by UUID.
This is an alternative solution to the issue in #1275 that also allows using other filter options like
apply_overrides=1.Why:
This error making get_results return no result at all was introduced in c9dc67a.
Before this special filter options like min_qod were simply ignored by
init_get_iterator2_with when getting single results, ensuring the result
would be visible.
How:
Response from GMP commands like these should include the result, even if result has min_qod < 70:
<get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69" filter="min_qod=70"/><get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69" filter="min_qod=0"/><get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69"/>Checklist: