Send NULL as extra_where_single in init_result_get_iterator #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents filters from having an effect when specifying a result_id in GET_RESULTS. This error was introduced in c9dc67a which introduced the extra_where_single arg. Before that there was no way to send extra args to init_get_iterator2_with when getting a single specified resource, which is equivalent to sending NULL now.
timopollmeier
requested changes
Aug 27, 2020
2 tasks
|
I've implemented a different solution that still applies other special keywords like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Prevents filters from having an effect when specifying a result_id in
GET_RESULTS.
Why:
This error was introduced in c9dc67a (from #1076) which
introduced the extra_where_single arg. Before that there was no way to
send extra args to init_get_iterator2_with when getting a single specified
resource, which is equivalent to sending NULL now.
How:
Response from each of these should include result, even if result has min_qod < 70:
2o m m '<get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69" filter="min_qod=70"/>'2o m m '<get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69" filter="min_qod=0"/>'2o m m '<get_results result_id="e89920a5-9af3-47af-975c-cb38cccdea69"/>'Checklist: