Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs 8 #964

Merged
merged 4 commits into from
Sep 21, 2018
Merged

Nodejs 8 #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
146ab81
Require nodejs 8.x
bjoernricks Sep 21, 2018
6958ea0
Update INSTALL for new node version
bjoernricks Sep 21, 2018
4cf21cf
Remove INSTALL section about nodejs-legacy link
bjoernricks Sep 21, 2018
f767d09
Merge branch 'master' into nodejs-8
bjoernricks Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions INSTALL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Compiling Greenbone Security Assistant GUI
------------------------------------------

Prerequisites for using the GUI:
* node.js >= 6.0
* node.js >= 8.0
* Either yarn or npm. yarn is faster and more reliable, but younger.

On Debian Stretch node.js is too old. Follow these steps for a
Expand All @@ -104,7 +104,7 @@ $ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sour
```
```sh
$ curl --silent --show-error https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -
$ echo "deb https://deb.nodesource.com/node_6.x jessie main" | sudo tee /etc/apt/sources.list.d/nodesource.list
$ echo "deb https://deb.nodesource.com/node_8.x stretch main" | sudo tee /etc/apt/sources.list.d/nodesource.list
```

```sh
Expand All @@ -115,12 +115,6 @@ $ sudo apt-get update
$ sudo apt-get install nodejs yarn
```

When using npm you might need to install the additional nodejs legacy symlink.

```sh
$ sudo apt-get install nodejs-legacy
```

Developing Greenbone Security Assistant GUI
-------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion gsa/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.

find_package (Node 6.0 REQUIRED)
find_package (Node 8.0 REQUIRED)
find_package (Yarn QUIET)

set (GSA_BUILD_DIR ${CMAKE_CURRENT_SOURCE_DIR}/build)
Expand Down
3 changes: 3 additions & 0 deletions gsa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"author": "Björn Ricks <[email protected]>",
"license": "GPL-2.0+",
"main": "src/index.js",
"engines": {
"node" : ">=8.0"
},
"eslintConfig": {
"extends": "react-app"
},
Expand Down