Nodejs 8 #964
Merged
Nodejs 8 #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs >= 8 is required for running the tests which use jest-styled-components now. Therefore set a required nodejs version in package.json and update the required version in the CMakeLists.txt file.
Debian stable is also stretch now.
This shouldn't be required anymore.
swaterkamp
approved these changes
Sep 21, 2018
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
=========================================
- Coverage 9.07% 9.05% -0.02%
=========================================
Files 819 819
Lines 26768 26772 +4
Branches 5715 5719 +4
=========================================
- Hits 2429 2425 -4
- Misses 21994 22001 +7
- Partials 2345 2346 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require nodejs version 8