Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting/displaying timeout in EditNvtDetailsDialog (backport #3057) #3087

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 23, 2021

This is an automatic backport of pull request #3057 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

The timeout is no longer parsed as string from the xml, which makes this
function obsolete and removing it prevents crashes due to the call of
String.prototype.trim()

(cherry picked from commit 55cd4c6)
(cherry picked from commit ee2c739)
@mergify mergify bot requested a review from a team as a code owner July 23, 2021 11:33
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #3087 (faa61cc) into master (5562557) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3087      +/-   ##
==========================================
- Coverage   57.70%   57.70%   -0.01%     
==========================================
  Files        1036     1036              
  Lines       25168    25165       -3     
  Branches     7197     7196       -1     
==========================================
- Hits        14524    14521       -3     
  Misses       9637     9637              
  Partials     1007     1007              
Impacted Files Coverage Δ
.../src/web/pages/scanconfigs/editnvtdetailsdialog.js 87.93% <100.00%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5562557...faa61cc. Read the comment docs.

@sarahd93 sarahd93 merged commit 0a13ad6 into master Jul 23, 2021
@sarahd93 sarahd93 deleted the mergify/bp/master/pr-3057 branch July 23, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants