Fix setting/displaying timeout in EditNvtDetailsDialog #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout is no longer parsed as string from the xml, which makes this function obsolete and removing it prevents crashes due to the call of String.prototype.trim()
Codecov Report
@@ Coverage Diff @@
## gsa-20.08 #3057 +/- ##
=============================================
- Coverage 53.74% 53.73% -0.01%
=============================================
Files 1073 1073
Lines 25912 25909 -3
Branches 7375 7374 -1
=============================================
- Hits 13926 13923 -3
Misses 10882 10882
Partials 1104 1104
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Jul 23, 2021
This was referenced Jul 23, 2021
bjoernricks
added a commit
that referenced
this pull request
Jul 23, 2021
Fix setting/displaying timeout in EditNvtDetailsDialog (backport #3057)
sarahd93
added a commit
that referenced
this pull request
Jul 23, 2021
Fix setting/displaying timeout in EditNvtDetailsDialog (backport #3057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove usage of
convertTimeout()in EditNvtDetailsDialogWhy:
convertTimeout()used String.protoype.trim() which crashes since the timeout is parsed asnumber. Since the new parsing, this function is obsolete anyway.Fixes AP-1004
How:
Manual tests to set and unset the timeout value and re-open the dialog.
Checklist: