Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to edit schedules with number only name (backport #2914) #2917

Merged
merged 4 commits into from
May 17, 2021
Merged

Fix unable to edit schedules with number only name (backport #2914) #2917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82fb90a
Fix unable to edit schedules with number only name
nichtsfrei May 17, 2021
53fd758
Update CHANGELOG.md
swaterkamp May 17, 2021
050041e
Update CHANGELOG.md
swaterkamp May 17, 2021
1900ef2
Use template literal for string conversion
bjoernricks May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Use greenbone sensor as default scanner type when opening the dialog if available [#2867](https://github.com/greenbone/gsa/pull/2867)

### Fixed
- Fixed number-only names within schedules/dialog [#2914](https://github.com/greenbone/gsa/pull/2914)
- Fixed changing Trend and Select for NVT-families and whole selection only [#2905](https://github.com/greenbone/gsa/pull/2905)
- Fixed missing name for CVE results on result detailspage [#2892](https://github.com/greenbone/gsa/pull/2892)
- Fix setting secret key in RADIUS dialog [#2891](https://github.com/greenbone/gsa/pull/2891)
Expand Down
5 changes: 4 additions & 1 deletion gsa/src/web/pages/schedules/dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,10 @@ class ScheduleDialog extends React.Component {
interval: isPreDefined ? 1 : interval,
monthdays: setMonthydays ? monthdays : undefined,
weekdays: setWeekdays ? weekdays : undefined,
summary: name,
// convert name to string explicitly to not run into:
// `TypeError: e.replace is not a function`
// when name is just numbers.
summary: `${name}`,
startDate,
},
timezone,
Expand Down