Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unable to edit schedules with number only name (backport #2914) #2917

Merged
merged 4 commits into from
May 17, 2021
Merged

Fix unable to edit schedules with number only name (backport #2914) #2917

merged 4 commits into from
May 17, 2021

Commits on May 17, 2021

  1. Fix unable to edit schedules with number only name 

    When adding a new schedule with a numbers only name `1234` and daily
re occurrence and trying to edit the new schedule than a:
```
TypeError: e.replace is not a function
```
occurs because name is a number and not a string.

To fix that name.toString() is called to explicitly cast it to string.

(cherry picked from commit 222ceda)
    @nichtsfrei
    nichtsfrei authored and mergify-bot committed May 17, 2021
    Configuration menu
    Copy the full SHA
    82fb90a View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    (cherry picked from commit 5a7327f)
    @swaterkamp
    swaterkamp authored and mergify-bot committed May 17, 2021
    Configuration menu
    Copy the full SHA
    53fd758 View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    (cherry picked from commit 8e5f1c1)
    @swaterkamp
    swaterkamp authored and mergify-bot committed May 17, 2021
    Configuration menu
    Copy the full SHA
    050041e View commit details
    Browse the repository at this point in the history

  4. Use template literal for string conversion 

    Using a template literal for converting an object to string is easier to read and imho safer to do.

(cherry picked from commit e948448)
    @bjoernricks
    bjoernricks authored and mergify-bot committed May 17, 2021
    Configuration menu
    Copy the full SHA
    1900ef2 View commit details
    Browse the repository at this point in the history