Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule improvements #1656

Merged
merged 4 commits into from
Oct 1, 2019
Merged

Schedule improvements #1656

merged 4 commits into from
Oct 1, 2019

Commits on Oct 1, 2019

  1. Fail safely if ical data couldn't be parsed 

    Don't crash the whole application if the ical data couldn't be parsed.
Instead log an error to the console and leave the schedule event
undefined.
    @bjoernricks
    bjoernricks committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    9e8c5fe View commit details
    Browse the repository at this point in the history

  2. Don't crash if schedule event is not available 

    If the event is undefined, e.g. when the ical data has errors, don't
crash the schedule details and list pages. Instead just don't show the
start and next dates.
    @bjoernricks
    bjoernricks committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    d113815 View commit details
    Browse the repository at this point in the history

  3. Add test for handling invalid ical data in schedules

    @bjoernricks
    bjoernricks committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    c027bb2 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry for invalid ical data handling

    @bjoernricks
    bjoernricks committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    4b8023f View commit details
    Browse the repository at this point in the history